Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the correct metric for errors #15

Merged
merged 7 commits into from
Sep 11, 2023
Merged

Conversation

karlhungus
Copy link
Contributor

@karlhungus karlhungus commented Sep 8, 2023

Fix: #14

  1. 🎩 πŸ’β€β™‚οΈ to @sidewinder12s for discovering that our error metrics were attempting to capture on the wrong metric 😬 , this fixes that by sending errors to the correct errors metric
  2. discvered how out of date skaffold was, so updated that
  3. while i was in there update to go 1.21

I didn't add a test for the failing case (I did verify this by lowering my docker timeouts and failing the request). Happy to split this up if it's too much

@karlhungus karlhungus requested a review from a team September 8, 2023 21:36
@karlhungus karlhungus marked this pull request as draft September 8, 2023 21:55
@karlhungus
Copy link
Contributor Author

Think i'm going to back off the golang updates, seems to break lots of things

@karlhungus karlhungus marked this pull request as ready for review September 8, 2023 22:02
@karlhungus karlhungus merged commit 37224db into main Sep 11, 2023
3 checks passed
@karlhungus karlhungus deleted the fix_error_metrics_capture branch September 11, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash/Panic on inconsistent labels
2 participants